Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: orphan info dialog #1142

Merged
merged 2 commits into from
Jan 14, 2024
Merged

feat: orphan info dialog #1142

merged 2 commits into from
Jan 14, 2024

Conversation

jsfez
Copy link
Contributor

@jsfez jsfez commented Jan 9, 2024

CleanShot 2024-01-11 at 12 40 28@2x

@jsfez jsfez requested review from a team and gregberge and removed request for a team January 9, 2024 19:33
Copy link

argos-ci bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Jan 11, 2024, 4:28 PM

@jsfez jsfez force-pushed the build-info-dialog branch from 3d0f5a3 to a9e1ed3 Compare January 9, 2024 19:36
Copy link
Member

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it simple, straight to the point.

apps/frontend/src/pages/Build/BuildInfoDialog.tsx Outdated Show resolved Hide resolved
apps/frontend/src/pages/Build/BuildInfoDialog.tsx Outdated Show resolved Hide resolved
apps/frontend/src/pages/Build/BuildInfoDialog.tsx Outdated Show resolved Hide resolved
apps/frontend/src/pages/Build/BuildInfoDialog.tsx Outdated Show resolved Hide resolved
apps/frontend/src/pages/Build/BuildInfoDialog.tsx Outdated Show resolved Hide resolved
apps/frontend/src/pages/Build/BuildInfoDialog.tsx Outdated Show resolved Hide resolved
apps/frontend/src/pages/Build/BuildInfoDialog.tsx Outdated Show resolved Hide resolved
apps/frontend/src/pages/Build/BuildInfoDialog.tsx Outdated Show resolved Hide resolved
apps/frontend/src/ui/Dialog.tsx Outdated Show resolved Hide resolved
@jsfez jsfez force-pushed the build-info-dialog branch 3 times, most recently from a31764b to 59850b1 Compare January 11, 2024 12:42
@jsfez jsfez force-pushed the build-info-dialog branch from 59850b1 to 3ac1a65 Compare January 11, 2024 15:38
@jsfez jsfez enabled auto-merge January 11, 2024 16:40
@jsfez jsfez disabled auto-merge January 14, 2024 10:27
@jsfez jsfez merged commit 4ffbef1 into main Jan 14, 2024
7 checks passed
@jsfez jsfez deleted the build-info-dialog branch January 14, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants